From 200cb48ad7aa23f220dd06fad83204b7565ea143 Mon Sep 17 00:00:00 2001 From: Marcin Macierzanka Date: Sun, 13 Sep 2026 16:41:59 +0200 Subject: [PATCH] refactor: simplify effects metadata tests and remove obsolete instance checks --- tests/test_effects.py | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/tests/test_effects.py b/tests/test_effects.py index 9580b98..c65bac3 100644 --- a/tests/test_effects.py +++ b/tests/test_effects.py @@ -89,22 +89,13 @@ class TestAudioEffects(unittest.TestCase): self.assertFalse(toggled) self.assertFalse(pipeline.is_active("distortion")) - def test_effects_metadata_does_not_contain_badge_or_description(self): + def test_effects_metadata_structure(self): from zyrarbot.audio.effects.registry import get_available_effects_metadata metadata = get_available_effects_metadata() self.assertGreater(len(metadata), 0) for entry in metadata: - self.assertIn("id", entry) - self.assertIn("name", entry) - self.assertIn("icon", entry) - self.assertNotIn("badge", entry) - self.assertNotIn("description", entry) - - def test_effect_instances_have_no_badge_or_description_attribute(self): - for effect in create_default_effects(): - self.assertFalse(hasattr(effect, "badge")) - self.assertFalse(hasattr(effect, "description")) + self.assertEqual(set(entry.keys()), {"id", "name", "icon"}) if __name__ == "__main__":